Docker-in-docker: Add retries to the docker-init script until docker daemon starts#637
Conversation
|
@samruddhikhandale Thank you! I hope this one will be prioritized. We experiencing a big dev experience issue working with inner loop env with a k8s cluster within the Codespaces. Every 3rd run fails, and we required to do full container rebuild.. sometimes multiple. |
jkeech
left a comment
There was a problem hiding this comment.
Can you add a test that verifies that the retries are working as expected? Left one comment about a breaking change. At minimum, this feels like a minor version bump to me since adding retries on the docker start is a new feature.
@jkeech Thanks for the review! Added a test which tests the retry logic and bumped the minor version. Also, see #637 (comment) |
jkeech
left a comment
There was a problem hiding this comment.
Approved with one suggestion
Closes: #634