Skip to content

Docker-in-docker: Add retries to the docker-init script until docker daemon starts#637

Merged
samruddhikhandale merged 2 commits intomainfrom
samruddhikhandale/dnd-retry-docker-init
Aug 7, 2023
Merged

Docker-in-docker: Add retries to the docker-init script until docker daemon starts#637
samruddhikhandale merged 2 commits intomainfrom
samruddhikhandale/dnd-retry-docker-init

Conversation

@samruddhikhandale
Copy link
Copy Markdown
Member

Closes: #634

@AndriiTsok
Copy link
Copy Markdown

@samruddhikhandale Thank you!

I hope this one will be prioritized. We experiencing a big dev experience issue working with inner loop env with a k8s cluster within the Codespaces. Every 3rd run fails, and we required to do full container rebuild.. sometimes multiple.

Copy link
Copy Markdown
Contributor

@jkeech jkeech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test that verifies that the retries are working as expected? Left one comment about a breaking change. At minimum, this feels like a minor version bump to me since adding retries on the docker start is a new feature.

Comment thread src/docker-in-docker/install.sh Outdated
@samruddhikhandale
Copy link
Copy Markdown
Member Author

Can you add a test that verifies that the retries are working as expected? Left one comment about a breaking change. At minimum, this feels like a minor version bump to me since adding retries on the docker start is a new feature.

@jkeech Thanks for the review! Added a test which tests the retry logic and bumped the minor version. Also, see #637 (comment)

Copy link
Copy Markdown
Contributor

@jkeech jkeech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with one suggestion

Comment thread test/docker-in-docker/test-scripts/docker-test-init.sh
@samruddhikhandale samruddhikhandale merged commit bbb24d1 into main Aug 7, 2023
@samruddhikhandale samruddhikhandale deleted the samruddhikhandale/dnd-retry-docker-init branch August 7, 2023 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Docker-in-docker: Add retry mechanism into the docker init script (Failed to connect to Docker)

3 participants