Conversation
nanafromjeju
requested review from
a user,
devdeun,
kimpra2989 and
ssumanlife
kimpra2989
approved these changes
Dec 9, 2024
Comment on lines
+25
to
+29
| if (response.data.isSuccess) { | ||
| return response.data.result | ||
| } else { | ||
| throw new Error(response.data.message || '요청 실패') | ||
| } |
There was a problem hiding this comment.
여기 early return으로 처리하면 더 깔끔할 것 같아요
if (!response.data.isSuccess) throw new Error(response.data.message || '요청 실패')
return response.data.result
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 풀 리퀘스트 제안
🔍 작업 내용
트레이더 페이지 API 추가
트레이더의 전략 데이터를 가져오는
getTraderStrategies API추가./api/strategies/search/trader/{traderId}경로를 통해 데이터를 조회합니다.반응형 디자인 추가
traders-list-wrapper에 반응형 스타일 적용:Tablet: 한 줄에 2개씩 표시.
Mobile: 한 줄에 1개씩 표시.
BackHeader 컴포넌트 Props 수정
기존 Props에
href?: string속성 추가.이를 통해 컴포넌트가 클릭 시 특정 경로로 이동할 수 있도록 설정.
🔧 변경 사항
📸 스크린샷
🙏 리뷰 참고
뒤로가기 버튼을 눌렀을때
router.back()가 안되는데 어떡하면 좋을지 알려주세요 눈물..