Skip to content

Add baseURL config option#20

Closed
jamesmosier wants to merge 5 commits intodevelopit:masterfrom
jamesmosier:patch/issue-12
Closed

Add baseURL config option#20
jamesmosier wants to merge 5 commits intodevelopit:masterfrom
jamesmosier:patch/issue-12

Conversation

@jamesmosier
Copy link
Copy Markdown
Contributor

@jamesmosier jamesmosier commented Apr 19, 2020 •
edited
Loading

Added the baseURL config option. This uses the same logic of adding combining the baseURL with the requested URL as axios.

Closes #12

@jamesmosier jamesmosier marked this pull request as ready for review April 19, 2020 16:23
@developit
Copy link
Copy Markdown
Owner

developit commented Apr 20, 2020

@googlebot test

@developit developit self-requested a review April 20, 2020 21:46
@sidoruk-sv
Copy link
Copy Markdown

sidoruk-sv commented Jun 17, 2020 •
edited
Loading

@developit HI!
Is there something that should be added here to be able to merge this?

@rschristian rschristian mentioned this pull request Jun 21, 2020
Closed
@developit
Copy link
Copy Markdown
Owner

developit commented Jul 15, 2020 •
edited
Loading

Thanks for the PR @jamesmosier! I've merged it but replaced the custom baseURL handling with the URL API for size reasons. (github's UI is being super weird today and shows this as closed, but it was definitely merged!)

@developit developit closed this Jul 15, 2020
@jamesmosier jamesmosier deleted the patch/issue-12 branch July 15, 2020 17:23
@kallyas kallyas mentioned this pull request Nov 12, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@developit developit Awaiting requested review from developit

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add baseURL

3 participants

@jamesmosier @developit @sidoruk-sv