Skip to content

"self" to not be a mandatory global variable#39

Merged
developit merged 1 commit intodevelopit:masterfrom
roymiloh:master
Jul 15, 2020
Merged

"self" to not be a mandatory global variable#39
developit merged 1 commit intodevelopit:masterfrom
roymiloh:master

Conversation

@roymiloh
Copy link
Copy Markdown
Contributor

Currently in case we want to use redaxios within a nodejs process, we have to define self on the global. This PR eliminates this requirement.

@googlebot
Copy link
Copy Markdown
Collaborator

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@roymiloh
Copy link
Copy Markdown
Contributor Author

@googlebot I signed it!

@googlebot
Copy link
Copy Markdown
Collaborator

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@developit developit merged commit bfff330 into developit:master Jul 15, 2020
@developit
Copy link
Copy Markdown
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants