fix: default credentials to same-origin#55
Merged
developit merged 1 commit intodevelopit:masterfrom Sep 1, 2020
Merged
Conversation
dhruvdutt
changed the title
Contributor
Author
|
@developit Please review. |
Owner
|
Seems like only Safari<12 in that list would have any usage. Still, probably worth including this fix. |
developit
approved these changes
Sep 1, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Even though based on docs it's default for most browsers, some browsers don't pass
same-originas default and not sending same origin cookies in fetch requests. The fix passessame-originby default explicitly infetch.References: