fix: updates error handling to match axios#56
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
7df96b1 to
2ccfc0c
Compare
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
|
@googlebot I fixed it. |
2ccfc0c to
2f65e83
Compare
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
|
@developit I was wondering if we could get this merged in? |
|
Sorry for the delay. |
developit
left a comment
There was a problem hiding this comment.
Excellent work. Only 3b larger!
|
Thanks for the fix! Would it be possible to have an npm release please? |
|
same here. @developit could you make a release, please? 🙏 |
|
BTW we should add a test, like the one in axios:
I don't know how to mock an API call that returns an error message with karmatic axios's project is using https://github.com/jasmine/jasmine-ajax - I wonder if need that too |
Ran into an issue where we are passing the error message as part of the 400/500 body. The current implementation drops that data, where axios returns the body.
#48