Skip to content

fix(types): return redaxios from create#68

Merged
developit merged 3 commits intodevelopit:masterfrom
dacioromero:master
Apr 29, 2022
Merged

fix(types): return redaxios from create#68
developit merged 3 commits intodevelopit:masterfrom
dacioromero:master

Conversation

@dacioromero
Copy link
Copy Markdown
Contributor

Currently the type generated for create is

    /**
     * @public
     */
    create: (defaults?: Options) => any;

Specifying the return type makes it

    /**
     * @public
     */
    create: typeof create;

and the new create type's return is the same as _default, but is unfortunately duplicated.

@googlebot
Copy link
Copy Markdown
Collaborator

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@dacioromero
Copy link
Copy Markdown
Contributor Author

@googlebot I signed it!

@googlebot
Copy link
Copy Markdown
Collaborator

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants