Fix types #26
Open
Fix types #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add types entry exports[0]. I'm sad TypeScript doesn't seem to be using the plain old types field but it isn't. - Replace index.d.ts' `export default` with `export =`[1]. From what I can tell, `module.exports` is always used for all entrypoints so this is the correct definition. - Use the Worker var declaration from lib.dom.d.ts. I think this is fine since the old definition already used the Worker interface from the same file. This typing is more accurate, easier to read,d less likely to become outdated, and less code. Bug: developit#20 developit#22 [0]: https://devblogs.microsoft.com/typescript/announcing-typescript-4-5-beta/#packagejson-exports-imports-and-self-referencing [1]: microsoft/TypeScript#7185 (comment)
Author
|
Hey @developit! Thank you for your awesome library! I'm a 1st time contributor to this repo so I need your bump to allow the workflow bots to run. |
Author
|
Hey @developit! Any chance you could take a look at this? My team is loving this library but all our types are showing up as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
using the plain old types field but it isn't.
export defaultwithexport =. From what Ican tell,
module.exportsis always used for all entrypoints so thisis the correct definition.
since the old definition already used the Worker interface from the
same file. This typing is more accurate, easier to read, less likely
to become outdated, and less code.
Bug: #20 #22