Conversation
|
@jjfrench I'll try to review in detail tomorrow. The first thing I noted is that we have no additional tests for the logic in this PR. A bit deeper look revealed that our CI actions are not running internal lib tests at all. @alukach Did you have a specific approach you'd like to see for running internal lib tests such as https://github.com/developmentseed/cdk-pgstac/blob/main/lib/ingestor-api/runtime/tests/test_registration.py for new PRs? I've never built a generic construct like this so I'm unsure what the best practice should be. @jjfrench I'll try to include the test runner in a separate PR and you may need to make an additional commit to trigger the automated action (preferably a commit containing a test for the new collection endpoint 😸 ) |
|
@jjfrench Here is the branch / PR with a test runner. You should be able to merge this branch and then build tests for your collection endpoint. |
Hey @sharkinsspatial, did you mean to link #10? Or was there another branch you were referencing? |
|
🤦 That's the one. |
|
@jjfrench I'm confused, it looks like that rather than fetching and merging my
|
Porting over changes from NASA-IMPACT/veda-stac-ingestor#29