Skip to content

feat!: set values.yaml tag to ""#1322

Merged
vincentsarago merged 1 commit intomainfrom
actually-use-appVersion
Feb 12, 2026
Merged

feat!: set values.yaml tag to ""#1322
vincentsarago merged 1 commit intomainfrom
actually-use-appVersion

Conversation

@ciaransweet
Copy link
Contributor

What this PR is

This is somewhat opinioated, but right now, because we're hardcoding tag: latest, appVersion is never chosen (ergo, pointless updating)

I've opted to blank out tag so that the default is the appVersion unless the deployer overrides the tag value. This feels more 'helm-y'

Also bumped the chart to a major version, given the major version change in titiler.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'TiTiler performance Benchmarks'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.30.

Benchmark suite Current: 2bdeb3b Previous: 60ef241 Ratio
WebMercator longest_transaction 0.07 s 0.05 s 1.40

This comment was automatically generated by workflow using github-action-benchmark.

@ciaransweet ciaransweet changed the title feat: set values.yaml tag to "" feat!: set values.yaml tag to "" Feb 12, 2026
@vincentsarago vincentsarago merged commit 5a79479 into main Feb 12, 2026
8 checks passed
@vincentsarago vincentsarago deleted the actually-use-appVersion branch February 12, 2026 17:09
vincentsarago added a commit that referenced this pull request Feb 12, 2026
@vincentsarago
Copy link
Member

sorry @emmanuelmathot I merged this before your review 😓

please let me know if you have any comments

@emmanuelmathot
Copy link
Contributor

totally fine with it.
Would worth to have release please here to take care of the helm chart versioning

@vincentsarago
Copy link
Member

yeah I would love to have release please set up in titiler 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants