Add git and openssh in the tooling image #100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`git` is required to perform some of the Go commands under some conditions (especially the `go test` command)
l0rd
approved these changes
Jul 20, 2020
sleshchenko
approved these changes
Jul 20, 2020
Member
sleshchenko
left a comment
sleshchenko
left a comment
There was a problem hiding this comment.
Just one comment: PR clearly describes why git is needed but no info about the use case for openssh.
Collaborator
Author
Afaict it's useful for git. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds
gitandopensshin the tooling image.gitis required to perform some of the Go commands under some conditions (especially thego testcommand)What issues does this PR fix or reference?
This PR is related to other PR #98 which introduces GO tests and add a
run testsdevfile command.Is your PR tested?
Yes, on che.penshift.io