Fix doc link in readme #1689
Merged
Fix doc link in readme #1689
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clayrosenthal
requested review from
a team,
AObuchow and
dkwon17
as code owners
clayrosenthal
force-pushed
the
fix-readme-doc-link
branch
from
d17e8f9 to
4166630
Compare
Member
michael-valdron
left a comment
michael-valdron
left a comment
There was a problem hiding this comment.
Needs rebase, recent PR merge fixes these failing checks: #1666
clayrosenthal
force-pushed
the
fix-readme-doc-link
branch
from
ece1a06 to
a610705
Compare
rephrasing to avoid using `here` for link text Signed-off-by: Clay Rosenthal <git@mail.clayrosenthal.me> Signed-off-by: Clay Rosenthal <clayros@amazon.com>
clayrosenthal
force-pushed
the
fix-readme-doc-link
branch
from
a610705 to
83171eb
Compare
Contributor
Author
|
@thepetk @michael-valdron rebased properly now |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: clayrosenthal, Jdubrick, michael-valdron, thepetk The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Updating the link to the generated documentation. Rephrasing to avoid using
herefor link text to have more readable links.Related Issue(s)
fixes #1688
Acceptance Criteria
If criteria is left unchecked please provide an explanation why.
No code changes
No code changes
Updating link
No code changes
Tests Performed
Clicked link.
How To Test
Click the link and don't end up with a dead page.
Notes To Reviewer
Feel free to rephrase if you don't like my wording.