Skip to content

Index server REST APIs docs #282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
GeekArthur merged 6 commits into from
Jan 11, 2021
Merged

Index server REST APIs docs #282

GeekArthur merged 6 commits into from
Jan 11, 2021

Conversation

@GeekArthur
Copy link
Contributor

@GeekArthur GeekArthur commented Dec 16, 2020

Signed-off-by: jingfu wang jingfu.j.wang@ibm.com

What does this PR do?

This PR adds the docs for index server REST APIs so that consumers (eg. Che) can refer to them.

@GeekArthur
docs: index server rest apis
7775f01 
Signed-off-by: jingfu wang <jingfu.j.wang@ibm.com>
@GeekArthur GeekArthur added the area/documentation Improvements or additions to documentation label Dec 16, 2020
@GeekArthur GeekArthur self-assigned this Dec 16, 2020
@GeekArthur
fix: placeholder syntax
0941467 
Signed-off-by: jingfu wang <jingfu.j.wang@ibm.com>
amisevsk
amisevsk reviewed Dec 17, 2020
View reviewed changes
elsony
elsony requested changes Dec 17, 2020
View reviewed changes
@GeekArthur
docs: address comments
5e7fb60 
Signed-off-by: jingfu wang <jingfu.j.wang@ibm.com>
johnmcollier
johnmcollier requested changes Dec 17, 2020
View reviewed changes
@GeekArthur
docs: add details
da8cce8 
Signed-off-by: jingfu wang <jingfu.j.wang@ibm.com>
@GeekArthur
docs: adjust format
3d149dd 
Signed-off-by: jingfu wang <jingfu.j.wang@ibm.com>
elsony
elsony approved these changes Dec 18, 2020
View reviewed changes
Copy link
Contributor

@elsony elsony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Approve based on the condition that we have confirmed the list of APIs needed by the Che team (especially around resource download APIs).

l0rd
l0rd reviewed Dec 28, 2020
View reviewed changes
l0rd
l0rd reviewed Dec 28, 2020
View reviewed changes
sleshchenko
sleshchenko reviewed Dec 28, 2020
View reviewed changes
This was referenced Jan 5, 2021
Closed
Merged
Merged
@GeekArthur
docs: address comments
42d68c5 
Signed-off-by: jingfu wang <jingfu.j.wang@ibm.com>
@GeekArthur
Copy link
Contributor Author

GeekArthur commented Jan 7, 2021

@l0rd @sleshchenko @johnmcollier @elsony @amisevsk Thanks for reviewing this PR, comments addressed, can you please review it again?

elsony
elsony approved these changes Jan 8, 2021
View reviewed changes
Copy link
Contributor

@elsony elsony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@GeekArthur GeekArthur mentioned this pull request Jan 11, 2021
Closed
4 tasks
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 11, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: elsony, GeekArthur, johnmcollier
To complete the pull request process, please assign after the PR has been reviewed.
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@GeekArthur GeekArthur merged commit 23ef66d into devfile:master Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@l0rd l0rd l0rd left review comments

@amisevsk amisevsk amisevsk left review comments

@johnmcollier johnmcollier johnmcollier approved these changes

@elsony elsony elsony approved these changes

@davidfestal davidfestal Awaiting requested review from davidfestal

+1 more reviewer

@sleshchenko sleshchenko sleshchenko left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@johnmcollier johnmcollier

@elsony elsony

@GeekArthur GeekArthur

Labels

area/documentation Improvements or additions to documentation lgtm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@GeekArthur @openshift-ci-robot @l0rd @sleshchenko @johnmcollier @elsony @amisevsk