-
Notifications
You must be signed in to change notification settings - Fork 74
Add tools for releasing the Devfile schema #285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Adds a script to run that upda - Adds a GitHub workflow action that publishes the released schemas to the Devfile website Signed-off-by: John Collier <jcollier@redhat.com>
Co-authored-by: Angel Misevski <amisevsk@redhat.com>
davidfestal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing more to comment than what @amisevsk pointed out.
As a side note, I'm just wondering what happens on the master branch after a release of the schemas (that happens in the release branch afaict). Is it bumped to the next alpha version that follows the last release version, or something like that ?
Do we want to define a process here as well ?
Co-authored-by: Angel Misevski <amisevsk@redhat.com>
Co-authored-by: Angel Misevski <amisevsk@redhat.com>
@davidfestal That's a good point, I think we've got a couple options here?
WDYT? |
- Remove force push when pushing to PR branch - Add check for proper schema version format - Add fix for schema versions where the patch version is >=10 Signed-off-by: John Collier <jcollier@redhat.com>
Signed-off-by: John Collier <jcollier@redhat.com>
|
I've updated this to include additional steps that opens a PR to bump the schema version on master (with a |
elsony
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This script automatically promotes the new version to stable and updating the minor version on the master branch. This script currently should be only be used on promoting code from master to a newer version. This may be sufficient for the time being but in case we need to do a service release on older versions and tries to run this script, we may end up moving stable to an earlier release. In order to avoid this potential problem, I wonder if we should:
- add an extra check on the new version that we are trying to declare to make sure it is a version later than the existing stable.
- if the new version that we try to set to is an earlier version than stable, we should probably prompt a warning as part of the script and saying we are trying to declare a release older than the existing stable release. The user can confirm it when running the script and it won't trigger the promotion to the stable nor updating the minor version on the master.
- Don't publish to stable if stable has a never version than what's being published - Don't update master schema version if the master version is newer than what's being published - Update design doc to clearly state that a Github token is required to run the script - Clean up the release script for some clarity Signed-off-by: John Collier <jcollier@redhat.com>
Signed-off-by: John Collier <jcollier@redhat.com>
|
@elsony Thanks for your review comments. I've updated the PR with the following changes:
|
Signed-off-by: John Collier <jcollier@redhat.com>
elsony
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: amisevsk, davidfestal, elsony, johnmcollier The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
What does this PR do?
This PR adds tools for releasing and publishing the Devfile schema, as outlined here:
make-release.shfrom https://github.com/che-incubator/chectl/blob/master/make-release.shWhat issues does this PR fix or reference?
Resolves #150
Is your PR tested? Consider putting some instruction how to test your changes
Yes.
For the
make-release.shscript:hubCLI is installed and theGITHUB_TOKENenvironment variable is set in your shell./make-release.sh <some-schema-version> v1alpha2For the GitHub action, see https://github.com/johnmcollier/api/runs/1558896668?check_suite_focus=true for what a sample run looks like.
Docs PR
N/A