Implement agreed-on devfile 2.0 issues #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Festal <dfestal@redhat.com>
Signed-off-by: David Festal <dfestal@redhat.com>
Signed-off-by: David Festal <dfestal@redhat.com>
Signed-off-by: David Festal <dfestal@redhat.com>
Signed-off-by: David Festal <dfestal@redhat.com>
Signed-off-by: David Festal <dfestal@redhat.com>
|
Open Developer Workspace: |
amisevsk
reviewed
Apr 3, 2020
Contributor
amisevsk
left a comment
amisevsk
left a comment
There was a problem hiding this comment.
A few comments/questions from a first pass over the changes.
|
Open Developer Workspace: |
Signed-off-by: David Festal <dfestal@redhat.com>
davidfestal
force-pushed
the
Implement-agreed-on-devfile-2.0-issues
branch
from
5b2ac1c to
c766457
Compare
|
Open Developer Workspace: |
PR comment is here: #35 (comment) Signed-off-by: David Festal <dfestal@redhat.com>
|
Open Developer Workspace: |
PR comment is here: #35 (comment) Signed-off-by: David Festal <dfestal@redhat.com>
|
Open Developer Workspace: |
Signed-off-by: David Festal <dfestal@redhat.com>
Signed-off-by: David Festal <dfestal@redhat.com>
|
Open Developer Workspace: |
Signed-off-by: David Festal <dfestal@redhat.com>
|
Open Developer Workspace: |
amisevsk
reviewed
Apr 14, 2020
Contributor
sleshchenko
reviewed
Apr 15, 2020
sleshchenko
reviewed
Apr 15, 2020
sleshchenko
reviewed
Apr 15, 2020
Signed-off-by: David Festal <dfestal@redhat.com>
|
Open Developer Workspace: |
Co-Authored-By: Sergii Leshchenko <sleshche@redhat.com>
|
Open Developer Workspace: |
1 similar comment
|
Open Developer Workspace: |
davidfestal
changed the title
Signed-off-by: David Festal <dfestal@redhat.com>
|
Open Developer Workspace: |
that doesn't impact the resulting schema Signed-off-by: David Festal <dfestal@redhat.com>
|
Open Developer Workspace: |
l0rd
approved these changes
Apr 22, 2020
This was
linked to
issues
Jun 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR implements the changes agreed on in the devfile 2.0 epic
What issues does this PR fix or reference?
#15