Github action for generating typescript models automatically from crds #384
Conversation
from crds Signed-off-by: Josh Pinkney <joshpinkney@gmail.com>
Signed-off-by: Josh Pinkney <joshpinkney@gmail.com>
JPinkney
requested review from
amisevsk,
davidfestal and
sleshchenko
as code owners
|
cc @benoitf since you were interested in this as well but I'm unable to add you as a reviewer |
Signed-off-by: Josh Pinkney <joshpinkney@gmail.com>
Signed-off-by: Josh Pinkney <joshpinkney@gmail.com>
|
@sleshchenko so let's try ? |
sleshchenko
left a comment
sleshchenko
left a comment
There was a problem hiding this comment.
I did not review the code in details, but in general LGTM.
I'm going to merge it but feel free to leave comments if any and they will be addressed in further PR
|
/approve |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: JPinkney, sleshchenko The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Merged. First job run failed due unclear reason https://github.com/devfile/api/runs/2191535613?check_suite_focus=true, but the rerun by Florent helped and now types are available https://www.npmjs.com/package/@devfile/api. |
5 participants
What does this PR do?
This PR introduces a github action for automatically generating typescript models from crds. It contains two things:
This approach makes it possible to generate types for any other language that is supported by kubernetes-client/gen. The only difference would be the release process.
@elsony Is it possible for someone from the devfile api team to create an organization on npm and add the npm token to this repo so that this github action can reference it?
What issues does this PR fix or reference?
#353
Is your PR tested? Consider putting some instruction how to test your changes
The github action was tested on my fork: https://github.com/JPinkney/api/actions
Docs PR