Deprecate v1alpha1 #639
Merged
Deprecate v1alpha1 #639
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Josh Pinkney <joshpinkney@gmail.com>
Signed-off-by: Josh Pinkney <joshpinkney@gmail.com>
Signed-off-by: Josh Pinkney <joshpinkney@gmail.com>
JPinkney
requested review from
amisevsk,
davidfestal and
sleshchenko
as code owners
Signed-off-by: Josh Pinkney <joshpinkney@gmail.com>
sleshchenko
approved these changes
Oct 8, 2021
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: amisevsk, JPinkney, sleshchenko The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
2 tasks
amisevsk
added a commit
to amisevsk/devworkspace-api
that referenced
this pull request
Jan 20, 2022
The v1alpha1 apiVersion of the DevWorkspace (and DevWorkspaceTemplate) CRD was removed prematurely as there are existing users that depend on it. This commit restores the v1alpha1 API as removed in PR devfile#639 in order to allow dependents of the DevWorkspace API to update to later versions of the v1alpha2 API without breaking v1alpha1 compatibility. Signed-off-by: Angel Misevski <amisevsk@redhat.com>
4 tasks
amisevsk
added a commit
to amisevsk/devworkspace-api
that referenced
this pull request
Jan 25, 2022
The v1alpha1 apiVersion of the DevWorkspace (and DevWorkspaceTemplate) CRD was removed prematurely as there are existing users that depend on it. This commit restores the v1alpha1 API as removed in PR devfile#639 in order to allow dependents of the DevWorkspace API to update to later versions of the v1alpha2 API without breaking v1alpha1 compatibility. Signed-off-by: Angel Misevski <amisevsk@redhat.com>
amisevsk
added a commit
that referenced
this pull request
Jan 26, 2022
The v1alpha1 apiVersion of the DevWorkspace (and DevWorkspaceTemplate) CRD was removed prematurely as there are existing users that depend on it. This commit restores the v1alpha1 API as removed in PR #639 in order to allow dependents of the DevWorkspace API to update to later versions of the v1alpha2 API without breaking v1alpha1 compatibility. Signed-off-by: Angel Misevski <amisevsk@redhat.com>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?:
This PR finally fully deprecates v1alpha1 and removes all references of it in the code
Which issue(s) this PR fixes:
#634
PR acceptance criteria:
Testing and documentation do not need to be complete in order for this PR to be approved. We just need to ensure tracking issues are opened.
Unit/Functional tests
QE Integration test
Documentation
Client Impact
How to test changes / Special notes to the reviewer: