Skip to content

Conversation

@kadel
Copy link
Member

@kadel kadel commented Jun 30, 2020

What does this PR do?

adds starterProject field

What issues does this PR fix or reference?

fixes #42

Is your PR tested? Consider putting some instruction how to test your changes

@kadel
Copy link
Member Author

kadel commented Jun 30, 2020

This is my first time contributing to this repo.
@davidfestal Please, let me know if there is something more that I need to do in this PR.

Copy link
Contributor

@amisevsk amisevsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

In the future, could you please separate out the auto-generated files into a separate commit to ease review?

@kadel
Copy link
Member Author

kadel commented Jul 1, 2020

In the future, could you please separate out the auto-generated files into a separate commit to ease review?

👍 Sure. I will make sure to do that.

@davidfestal
Copy link
Collaborator

I'm reviewing it.

@davidfestal davidfestal self-requested a review July 2, 2020 16:09
@kadel kadel force-pushed the add-starterProject branch from e519a7c to 162e4df Compare July 14, 2020 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

starterProjects and projects description

4 participants