Fix Viewer tags issue #103
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
kim-tsao
approved these changes
Oct 23, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kim-tsao, thepetk The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
thepetk
added a commit
that referenced
this pull request
Oct 23, 2023
* Add functions for devfile tags Signed-off-by: thepetk <thepetk@gmail.com> * Update detailed view and grid Signed-off-by: thepetk <thepetk@gmail.com> * Create new color in tailwind Signed-off-by: thepetk <thepetk@gmail.com> * Apply format Signed-off-by: thepetk <thepetk@gmail.com> --------- Signed-off-by: thepetk <thepetk@gmail.com>
thepetk
added a commit
that referenced
this pull request
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do / why we need it
This PR fixes the issue of tags not getting updated when a user chooses another version of the stack. So it updates the detailed view of the stack to show every time the tags of the selected version.
On the other hand it adds a check to the grid and the detailed view. If a tag is named
Deprecatedit updates the color of the tag from blue to red.Other than that unit tests have been added for all new functions.
Example Screenshots
Grid View with a default version
Deprecatedtag:Detailed view with deprecated:
Detailed view of another version not having
Deprecatedtag:Which issue(s) does this PR fix
Fixes devfile/api#1289
PR acceptance criteria
How to test changes / Special notes to the reviewer
stackwith aDeprecatedtag inside, run locally theregistry-viewerapp:yarn nx serve registry-viewer --configuration=development