-
Notifications
You must be signed in to change notification settings - Fork 67
Description
Description
Since PR #827, it's possible to configure the PVC size used for both per-workspace and common PVCs. However, after a PVC is created, the storage size is not updated, and so the only way to reflect changes to the configuration is to first delete all DevWorkspaces in the namespace that use that PVC, allow the PVC to be cleaned up, and then recreate it by creating a new DevWorkspace (see #834).
Some persistent volume storage-classes support resizing PVCs. When this is possible, DWO should attempt to automatically increase PVC sizes if it detects that an existing PVC is smaller than the configured default.
This resize could potentially be performed on-demand, e.g. the next time a workspace is started. We do have to be a little careful as resizing potentially hundreds of PVCs could impact cluster stability/performance.
Additional context
Further notes:
- Since we currently don't update PVCs once they are created, there is a chance that the PVC has already been configured by users. Likely the implementation should only increase PVC size (if the default is less than the existing PVC's size, we do nothing).
- This feature has a potential performance impact, and it would be necessary to verify that updating the default storage size will not adversely impact performance/stability in large clusters (with potentially hundreds of affected PVCs)