-
Notifications
You must be signed in to change notification settings - Fork 67
Add DevWorkspace Pruner (operator-lib/prune package) #1402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Skipping CI for Draft Pull Request. |
4a44124 to
4dc83c6
Compare
Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
…rate_all Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
4dc83c6 to
cdbf388
Compare
Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
78b0e3d to
3218747
Compare
Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
|
/retest |
|
@akurinnoy: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
ibuziuk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@akurinnoy great job, could you please provide a separate PR with the docs to https://github.com/devfile/devworkspace-operator/blob/main/docs/dwo-configuration.md
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: akurinnoy, ibuziuk The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
What does this PR do?
This pull request adds a new controller that prunes (removes) DevWorkspaces based on these rules:
DevWorkspaceOperatorConfig(DWOC) resource.cronlibrary, allowing for flexible configuration of the pruning frequency.What issues does this PR fix or reference?
resolves #1376
Is it tested? How?
DevWorksapceOperatorConfiginitially does not have pruning enabled by defaultCleanupCronJobsection in theconfig.workspacesection of the DWOC.CleanupCronJobsection, ensure thatenable: false.DevWorkspaceOperatorConfigto enable pruning and set parameters:kubectl patch DevWorkspaceOperatorConfig devworkspace-operator-config \ -n devworkspace-controller \ --type=merge \ -p '{"config": {"workspace": {"cleanupCronJob": {"enable": true, "dryRun": true, "retainTime": 60, "schedule": "* * * * *"}}}}'kubectl patch DevWorkspaceOperatorConfig devworkspace-operator-config \ -n devworkspace-controller \ --type=merge \ -p '{"config": {"workspace": {"cleanupCronJob": {"dryRun": false }}}}'PR Checklist
/test v8-devworkspace-operator-e2e, v8-che-happy-pathto trigger)v8-devworkspace-operator-e2e: DevWorkspace e2e testv8-che-happy-path: Happy path for verification integration with Che