Skip to content

Conversation

@rohanKanojia
Copy link
Member

What does this PR do?

  • Introduced WAIT variable to wait until DevWorkspace Deployment becomes ready
  • Added conditional shell logic to wait before proceeding

What issues does this PR fix or reference?

Fix #1456

Is it tested? How?

Run make install WAIT=true You'll see that it would wait for Deployments to get ready:

⌛ Waiting for DevWorkspace Operator deployments to get ready
Waiting for deployment "devworkspace-controller-manager" rollout to finish: 0 of 1 updated replicas are available...
deployment "devworkspace-controller-manager" successfully rolled out
Waiting for deployment "devworkspace-webhook-server" rollout to finish: 0 of 2 updated replicas are available...
Waiting for deployment "devworkspace-webhook-server" rollout to finish: 1 of 2 updated replicas are available...
deployment "devworkspace-webhook-server" successfully rolled out
✅ Installation Successful

Run it without any option, make install. You'll see that no waiting is performed:

service/devworkspace-controller-metrics created
deployment.apps/devworkspace-controller-manager created
devworkspaceoperatorconfig.controller.devfile.io/devworkspace-operator-config created
✅ Installation Successful

PR Checklist

  • E2E tests pass (when PR is ready, comment /test v8-devworkspace-operator-e2e, v8-che-happy-path to trigger)
    • v8-devworkspace-operator-e2e: DevWorkspace e2e test
    • v8-che-happy-path: Happy path for verification integration with Che

…running (devfile#1456)

- Introduced WAIT variable  to wait until all operands are running
- Added conditional shell logic to wait before proceeding

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
Copy link
Collaborator

@dkwon17 dkwon17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you, merging

@openshift-ci
Copy link

openshift-ci bot commented Jun 26, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dkwon17, rohanKanojia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dkwon17 dkwon17 merged commit f45fd01 into devfile:main Jun 26, 2025
10 checks passed
@rohanKanojia rohanKanojia deleted the pr/issue1456 branch June 27, 2025 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Provide option for make install to wait until all operands are running

2 participants