test(e2e): fix debug mode test timing and add PVC cleanup #1554
Conversation
Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: akurinnoy, rohanKanojia The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Thanks a lot for the fix! Do you think it fixes #1535 ? |
| ginkgo.AfterEach(func() { | ||
| // Clean up workspace and wait for PVC to be fully deleted | ||
| // This prevents PVC conflicts in subsequent tests, especially in CI environments | ||
| _ = config.DevK8sClient.DeleteDevWorkspaceAndWait(workspaceName, config.DevWorkspaceNamespace) |
There was a problem hiding this comment.
Should this cleanup block also be required for other tests?
|
/ok-to-test |
|
@akurinnoy: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
2 participants
What does this PR do?
This PR fixes the debug mode e2e test: waits the test devworkspace for Running status instead of Starting. Also, is adds the AfterEach cleanup step to prevent PVC conflicts.
What issues does this PR fix or reference?
Is it tested? How?
PR Checklist
/test v8-devworkspace-operator-e2e, v8-che-happy-pathto trigger)v8-devworkspace-operator-e2e: DevWorkspace e2e testv8-che-happy-path: Happy path for verification integration with Che