docs: clarify that registry.authSecret must be labeled for operator detection
#1558
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etection Signed-off-by: Rohan Kumar <rohaan@redhat.com>
rohanKanojia
requested review from
akurinnoy,
dkwon17 and
ibuziuk
as code owners
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: rohanKanojia The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
rohanKanojia
changed the title
registry.authSecret must be labeled for operator detection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Clarifies the documentation for
registry.authSecretby explicitly stating that the referenced Kubernetes Secret must be labeled withcontroller.devfile.io/watch-secret=trueto be detected and used by the DevWorkspace Operator.This prevents confusion when valid registry credentials are ignored due to missing labels. I was confused as I was following this documentation and not labeling the secret.
What issues does this PR fix or reference?
Related to #1556
Is it tested? How?
N/A (documentation-only change.)
PR Checklist
/test v8-devworkspace-operator-e2e, v8-che-happy-pathto trigger)v8-devworkspace-operator-e2e: DevWorkspace e2e testv8-che-happy-path: Happy path for verification integration with Che