Remove Component CRD and related code #336
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the components.controller.devfile.io Custom Resource Definition from the repo, as it is unused in adopting devfile 2.0 more directly (pkg/flatten). Signed-off-by: Angel Misevski <amisevsk@redhat.com>
Collaborator
Author
|
/test v5-devworkspaces-operator-e2e |
sleshchenko
approved these changes
Mar 19, 2021
Member
sleshchenko
left a comment
sleshchenko
left a comment
There was a problem hiding this comment.
LGTM
We need to sync with deploy team when we change our deployments, ideally we can provide fixes for che operator and chectl
Member
|
It must be merged before the release |
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: amisevsk, JPinkney, sleshchenko The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This was referenced Mar 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Remove the Components CRD. This subresource is unused since #237 but CRDs were left for compatibility.
What issues does this PR fix or reference?
Follow up to #237
Is it tested? How?
Test as normal; should be no functional changes as #237 removed the Components controller.