Skip to content

Conversation

@jc-berger
Copy link
Contributor

Fixes #191 Define onboarding requirement

Taking content from John's devfile-registry docs repo: https://github.com/johnmcollier/registry-docs

I've left comments throughout the docs, asking questions to help direct peer reviewers' attention.

Thanks!

@johnmcollier or @GeekArthur would either of you take a look please to see how the devfile registry docs are looking?

@jc-berger jc-berger added the documentation Improvements or additions to documentation label Jun 2, 2021
@jc-berger jc-berger self-assigned this Jun 2, 2021
Copy link
Member

@johnmcollier johnmcollier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks fine to me. Just left a couple small comments

jc-berger and others added 7 commits June 7, 2021 15:44
@jc-berger
Copy link
Contributor Author

jc-berger commented Jun 7, 2021

@johnmcollier if you could take another look and give it the LGTM if you think it looks good.

Apologies for the many commits...I accepted Rolfe's changes than made several myself, resulting in lots of commits! Thanks for the help!

Co-authored-by: Rolfe Dlugy-Hegwer <rolfedh@users.noreply.github.com>
Copy link
Contributor

@rolfedh rolfedh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment. Otherwise, /lgtm

@openshift-ci
Copy link

openshift-ci bot commented Jun 8, 2021

@rolfedh: changing LGTM is restricted to collaborators

Details

In response to this:

One minor comment. Otherwise, /lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jc-berger
Copy link
Contributor Author

@rkratky gotten the LTM from docs and devs. Please let me know if there's anything you would like me to address or change before you merge, thanks!

Copy link

@rkratky rkratky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jc-berger, comments added.

jc-berger and others added 11 commits June 21, 2021 12:57
Co-authored-by: Robert Krátký <rkratky@redhat.com>
Co-authored-by: Robert Krátký <rkratky@redhat.com>
Co-authored-by: Robert Krátký <rkratky@redhat.com>
Co-authored-by: Robert Krátký <rkratky@redhat.com>
Co-authored-by: Robert Krátký <rkratky@redhat.com>
Co-authored-by: Robert Krátký <rkratky@redhat.com>
Co-authored-by: Robert Krátký <rkratky@redhat.com>
Co-authored-by: Robert Krátký <rkratky@redhat.com>
Co-authored-by: Robert Krátký <rkratky@redhat.com>
Co-authored-by: Robert Krátký <rkratky@redhat.com>
@jc-berger
Copy link
Contributor Author

@rkratky, addressed your comment and made some more changes in my new commit. Also, you'll see a comment I made pointing out the many uses of passive voice.

If you think it all looks fine, please go ahead and merge. Otherwise, I'm happy to continue to make changes. Thanks!

@openshift-ci openshift-ci bot added the lgtm label Jun 24, 2021
@openshift-ci
Copy link

openshift-ci bot commented Jun 24, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jc-berger, johnmcollier, rkratky, rolfedh

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rkratky rkratky merged commit 46d9d72 into devfile:master Jun 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation lgtm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Define onboarding requirement for a stack to be added to a public registry (include documentation on the devfile public website)

4 participants