Updating go version to 1.24, making changes to reflect stricter linti… #108
Conversation
JslYoon
force-pushed
the
JslYoon/UpdateGo1.24
branch
from
65c625f to
4c30850
Compare
thepetk
left a comment
thepetk
left a comment
There was a problem hiding this comment.
looking at this one and the failing tests, I'm just thinking is it even a requirement to run 4.11 to 4.15 tests anymore?
cc @michael-valdron wdyt?
Yeah, looks like its something to do with the base image go version, so we'd have to change the base image? |
…ng policies Signed-off-by: Lucas Yoon <lyoon@lyoon-thinkpadp1gen7.boston.csb>
JslYoon
force-pushed
the
JslYoon/UpdateGo1.24
branch
from
4c30850 to
bb42a0b
Compare
|
/retest |
@thepetk @JslYoon These are quite old yeah, I'd recommend changing the target OCP versions here to v4.16, v4.17, v4.18. |
|
/test all |
|
@johnmcollier We'll need to switch the required checks to the new checks here. |
|
/retest |
1 similar comment
|
/retest |
|
/retest |
JslYoon
force-pushed
the
JslYoon/UpdateGo1.24
branch
2 times, most recently
from
5e78cf3 to
ef41785
Compare
michael-valdron
left a comment
michael-valdron
left a comment
There was a problem hiding this comment.
@JslYoon Nice job, console testing is now passing!
Aside from my nit comment, I'll take a look at the odo piece before approving, I believe this check will need to be force merged.
Signed-off-by: Lucas Yoon <lyoon@lyoon-thinkpadp1gen7.boston.csb>
JslYoon
force-pushed
the
JslYoon/UpdateGo1.24
branch
from
ef41785 to
dfdece6
Compare
|
@JslYoon: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
michael-valdron
left a comment
michael-valdron
left a comment
There was a problem hiding this comment.
/lgtm
@johnmcollier It appears that the odo checks are checking out from main rather than the PR branch, we'll need to force merge to get past this, are you still able to do this?
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JslYoon, michael-valdron The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…ng policies
What does this PR do?
Updating go version form 1.21 to 1.24
What issues does this PR fix or reference?
devfile/api#1708