Skip to content

Conversation

@josephca
Copy link
Collaborator

@josephca josephca commented May 16, 2022

What does this PR do?

This PR adds integration tests to verify the devfile library and API against test devfiles.

What issues does this PR fix or reference?

Fixes devfile/api#850

Is your PR tested? Consider putting some instruction how to test your changes

Tested locally and by using PR test

josephca added 2 commits May 16, 2022 17:26
Signed-off-by: Joseph Kim <joskim@redhat.com>
Signed-off-by: Joseph Kim <joskim@redhat.com>
@openshift-ci openshift-ci bot requested a review from elsony May 16, 2022 21:35
@openshift-ci
Copy link

openshift-ci bot commented May 16, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: josephca

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

josephca added 3 commits May 17, 2022 14:18
Signed-off-by: Joseph Kim <joskim@redhat.com>
Signed-off-by: Joseph Kim <joskim@redhat.com>
Signed-off-by: Joseph Kim <joskim@redhat.com>
@josephca josephca marked this pull request as draft May 17, 2022 18:48
josephca added 2 commits May 17, 2022 16:28
Signed-off-by: Joseph Kim <joskim@redhat.com>
Signed-off-by: Joseph Kim <joskim@redhat.com>
@josephca josephca marked this pull request as ready for review May 18, 2022 17:22
@josephca josephca merged commit 52ef38b into devfile:main May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

integration tests for library and API

1 participant