Skip to content

Conversation

@yangcao77
Copy link
Collaborator

Signed-off-by: Stephanie yangcao@redhat.com

What does this PR do?

This PR introduced a new function to get networking.k8s.io/v1 ingress, since v1beta1 ingress is no longer supported in future versions of k8s api

What issues does this PR fix or reference?

Fixes devfile/api#504

Is your PR tested? Consider putting some instruction how to test your changes

Added new unit test

Signed-off-by: Stephanie <yangcao@redhat.com>
@yangcao77 yangcao77 requested a review from maysunfaisal June 23, 2021 17:40
@openshift-ci openshift-ci bot requested a review from elsony June 23, 2021 17:40
@yangcao77
Copy link
Collaborator Author

@mohammedzee1000 Can you help review the PR to see if this is what Odo looking for?

Copy link
Contributor

@mohammedzee1000 mohammedzee1000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep. this is what odo id looking for.

Eventually (once openshift 3.11 is phased out), we should no longer need generator for extensions v1 beta1 ingress, but for now, this looks good

@openshift-ci
Copy link

openshift-ci bot commented Jun 25, 2021

@mohammedzee1000: changing LGTM is restricted to collaborators

Details

In response to this:

yep. this is what odo id looking for.

Eventually (once openshift 3.11 is phased out), we should no longer need generator for extensions v1 beta1 ingress, but for now, this looks good

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented Jun 25, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maysunfaisal, mohammedzee1000, yangcao77

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [maysunfaisal,yangcao77]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yangcao77 yangcao77 merged commit a43568f into devfile:main Jun 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Kubernetes-Breaking-Change] Add library ingress generator for networking v1 ingress as extension v1beta1 ingress

3 participants