Skip to content

Conversation

@kim-tsao
Copy link
Contributor

What does this PR do?:

  • Updates tests and utils to use boolean pointers
  • Updates the parser tests to v2.1.0 and expands coverage to include all boolean fields

Which issue(s) this PR fixes:

devfile/api#545

PR acceptance criteria:

Testing and documentation do not need to be complete in order for this PR to be approved. We just need to ensure tracking issues are opened.

  • Open new test/doc issues under the devfile/api repo
  • Check each criteria if:
  • There is a separate tracking issue. Add the issue link under the criteria
    or
  • test/doc updates are made as part of this PR
  • If unchecked, explain why it's not needed

N/A

  • Documentation

N/A

  • Client Impact

Client impact discussion in issue devfile/api#545

How to test changes / Special notes to the reviewer:

@kim-tsao kim-tsao marked this pull request as ready for review September 15, 2021 17:06
@openshift-ci openshift-ci bot added the lgtm label Sep 17, 2021
@openshift-ci
Copy link

openshift-ci bot commented Sep 17, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kim-tsao, yangcao77

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kim-tsao kim-tsao merged commit 202fa98 into devfile:main Sep 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants