Skip to content

update library for image component type #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yangcao77 merged 2 commits into from
Sep 23, 2021
Merged

update library for image component type #118

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5fc824e
add image component to helper function
yangcao77 Sep 22, 2021
197718d
remove json file name
yangcao77 Sep 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions pkg/devfile/parser/data/v2/common/component_helper.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,8 @@ func GetComponentType(component v1.Component) (v1.ComponentType, error) {
return v1.KubernetesComponentType, nil
case component.Openshift != nil:
return v1.OpenshiftComponentType, nil
case component.Image != nil:
return v1.ImageComponentType, nil
case component.Custom != nil:
return v1.CustomComponentType, nil

Expand Down
10 changes: 10 additions & 0 deletions pkg/devfile/parser/data/v2/common/component_helper_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,6 +150,16 @@ func TestGetComponentType(t *testing.T) {
},
componentType: v1.PluginComponentType,
},
{
name: "Image component",
component: v1.Component{
Name: "name",
ComponentUnion: v1.ComponentUnion{
Image: &v1.ImageComponent{},
},
},
componentType: v1.ImageComponentType,
},
{
name: "Custom component",
component: v1.Component{
Expand Down
1 change: 0 additions & 1 deletion pkg/devfile/parser/devfileobj.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ import (

// Default filenames for create devfile
const (
OutputDevfileJsonPath = "devfile.json"
OutputDevfileYamlPath = "devfile.yaml"
)

Expand Down