Version checks for boolean properties

[kim-tsao]

What does this PR do?:

Adds a version check when setting defaults for the ephemeral property

Which issue(s) this PR fixes:

devfile/api#697

PR acceptance criteria:

Testing and documentation do not need to be complete in order for this PR to be approved. We just need to ensure tracking issues are opened.

• Open new test/doc issues under the devfile/api repo
• Check each criteria if:
• There is a separate tracking issue. Add the issue link under the criteria
  or
• test/doc updates are made as part of this PR
• If unchecked, explain why it's not needed

• Unit/Functional tests

The functional tests only cover what's fixed in the defect. Additional coverage will be handled in this issue devfile/api#655

• QE Integration test

• Documentation

• Client Impact

How to test changes / Special notes to the reviewer:

build a new odo binary and run the scenario detailed in devfile/api#697

[feloy]

This patch fixes the issue raised in #697. Thanks @kim-tsao

[yangcao77]

thanks for the change Kim. besides the comment I put below, can you also add unit tests for setDefaults() and the new function,verifyEphemeralUnset(), introduced by this PR?
we want to have new functions also covered by unit tests

[yangcao77]

DevfileObj.Ctx.GetApiVersion() should take higher priority than Data.GetSchemaVersion().

	if devfileVersion = DevfileObj.Ctx.GetApiVersion(); devfileVersion == "" {
		devfileVersion = DevfileObj.Data.GetSchemaVersion()
	}

[kim-tsao]

thanks for the change Kim. besides the comment I put below, can you also add unit tests for setDefaults() and the new function,verifyEphemeralUnset(), introduced by this PR? we want to have new functions also covered by unit tests

verifyEphemeralUnset() is just a new function in our test utils. I added unit tests for setDefaults() - it was a worthwhile effort since I found and fixed a bug related to setting defaults on dedicatedPod and mountSources. I also cleaned up some error handling that was missed.

[yangcao77]

Changes lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kim-tsao, yangcao77

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [kim-tsao,yangcao77]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment