Skip to content

Update ingress from extension to networking api #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maysunfaisal merged 1 commit into from
Dec 7, 2022
Merged

Update ingress from extension to networking api #159

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions pkg/devfile/parser/reader.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ import (
routev1 "github.com/openshift/api/route/v1"
appsv1 "k8s.io/api/apps/v1"
corev1 "k8s.io/api/core/v1"
extensionsv1 "k8s.io/api/extensions/v1beta1"
networkingv1 "k8s.io/api/networking/v1"
)

// YamlSrc specifies the src of the yaml in either Path, URL or Data format
Expand All @@ -48,7 +48,7 @@ type KubernetesResources struct {
Deployments []appsv1.Deployment
Services []corev1.Service
Routes []routev1.Route
Ingresses []extensionsv1.Ingress
Ingresses []networkingv1.Ingress
Others []interface{}
}

Expand Down Expand Up @@ -106,14 +106,14 @@ func ParseKubernetesYaml(values []interface{}) (KubernetesResources, error) {
var deployments []appsv1.Deployment
var services []corev1.Service
var routes []routev1.Route
var ingresses []extensionsv1.Ingress
var ingresses []networkingv1.Ingress
var otherResources []interface{}

for _, value := range values {
var deployment appsv1.Deployment
var service corev1.Service
var route routev1.Route
var ingress extensionsv1.Ingress
var ingress networkingv1.Ingress
var otherResource interface{}

byteData, err := k8yaml.Marshal(value)
Expand Down