Skip to content

Conversation

@yangcao77
Copy link
Collaborator

What does this PR do?:

This issue fixes the bug that if the uri is not able to resolve from rawcontent, it will be ignored. Now it errors out with the message error getting kubernetes resources definition information, unable to resolve the file uri: %v", uri
Also added test for the function getKubernetesDefinitionFromUri, where the bug was found.

Which issue(s) this PR fixes:

Fixes devfile/api#1039

PR acceptance criteria:

Testing and documentation do not need to be complete in order for this PR to be approved. We just need to ensure tracking issues are opened.

  • Open new test/doc issues under the devfile/api repo
  • Check each criteria if:
  • There is a separate tracking issue. Add the issue link under the criteria
    or
  • test/doc updates are made as part of this PR
  • If unchecked, explain why it's not needed

How to test changes / Special notes to the reviewer:

Signed-off-by: Stephanie <yangcao@redhat.com>
@openshift-ci
Copy link

openshift-ci bot commented Feb 22, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kim-tsao, yangcao77

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yangcao77 yangcao77 merged commit 539d4b1 into devfile:main Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Library should error out if kube uri is not able to resolve when parsing from byte[]

2 participants