Skip to content

Conversation

@michael-valdron
Copy link
Member

@michael-valdron michael-valdron commented Jun 18, 2025

Description of Changes

Updates OpenShift requirements under the documentation to specify 4.15.x-4.18.x compatibility and indicate that the Operator is actively tested on OpenShift v4.18.

Related Issue(s)

resolves devfile/api#1669

Acceptance Criteria

Tests

  • Test Coverage
    • Are your changes sufficiently tested, and are any applicable test cases added or updated to cover your changes?
  • Gosec scans

Documentation

  • Does the registry operator documentation need to be updated with your changes?

Tests Performed

Ran make test-integration on an active deployment of the current state of main. Tested against OpenShift 4.16-4.18.

How To Test

Running Unit Tests

Running Integration Tests

Notes To Reviewer

Signed-off-by: Michael Valdron <mvaldron@redhat.com>
@openshift-ci openshift-ci bot requested review from Jdubrick and thepetk June 18, 2025 19:57
@michael-valdron
Copy link
Member Author

/hold

Waiting for v4.18 testing setup to be merged: openshift/release#66235

@codecov
Copy link

codecov bot commented Jun 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 34.27%. Comparing base (7b69290) to head (cad92a8).
Report is 18 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #106      +/-   ##
==========================================
+ Coverage   28.34%   34.27%   +5.93%     
==========================================
  Files          25       30       +5     
  Lines        1450     1838     +388     
==========================================
+ Hits          411      630     +219     
- Misses       1018     1184     +166     
- Partials       21       24       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@thepetk thepetk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

\lgtm

is using as well as the API overlap between OpenShift and
Kubernetes.

Operator currently targets Kubernetes 1.29 API and is tested on OpenShift 4.15.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit but doesn't need to be added: should we link to the kube api and openshift 4.18

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Jdubrick I've added links to the release notes of these versions: 629ad36

Signed-off-by: Michael Valdron <mvaldron@redhat.com>
@openshift-ci openshift-ci bot removed the lgtm label Jun 19, 2025
@michael-valdron michael-valdron requested a review from Jdubrick June 19, 2025 20:22
@michael-valdron
Copy link
Member Author

/unhold

openshift/release#66235 has been merged.

Copy link
Contributor

@Jdubrick Jdubrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@openshift-ci openshift-ci bot added the lgtm label Jun 23, 2025
@openshift-ci
Copy link

openshift-ci bot commented Jun 23, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jdubrick, michael-valdron, thepetk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [Jdubrick,michael-valdron,thepetk]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@michael-valdron michael-valdron merged commit c282781 into devfile:main Jun 23, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade registry operator to use OpenShift 4.18 testing

3 participants