-
Notifications
You must be signed in to change notification settings - Fork 23
Update openshift requirements under docs #106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update openshift requirements under docs #106
Conversation
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
|
/hold Waiting for v4.18 testing setup to be merged: openshift/release#66235 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #106 +/- ##
==========================================
+ Coverage 28.34% 34.27% +5.93%
==========================================
Files 25 30 +5
Lines 1450 1838 +388
==========================================
+ Hits 411 630 +219
- Misses 1018 1184 +166
- Partials 21 24 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
thepetk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
\lgtm
| is using as well as the API overlap between OpenShift and | ||
| Kubernetes. | ||
|
|
||
| Operator currently targets Kubernetes 1.29 API and is tested on OpenShift 4.15. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit but doesn't need to be added: should we link to the kube api and openshift 4.18
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
|
/unhold openshift/release#66235 has been merged. |
Jdubrick
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Jdubrick, michael-valdron, thepetk The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description of Changes
Updates OpenShift requirements under the documentation to specify 4.15.x-4.18.x compatibility and indicate that the Operator is actively tested on OpenShift v4.18.
Related Issue(s)
resolves devfile/api#1669
Acceptance Criteria
Tests
Documentation
Tests Performed
Ran
make test-integrationon an active deployment of the current state of main. Tested against OpenShift 4.16-4.18.How To Test
Running Unit Tests
Running Integration Tests
Notes To Reviewer