Skip to content

Add download-starter-projects to Registry Library APIs #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
michael-valdron merged 27 commits into from
Jul 12, 2022
Merged

Add download-starter-projects to Registry Library APIs #126

michael-valdron merged 27 commits into from
Jul 12, 2022

Conversation

@michael-valdron
Copy link
Member

@michael-valdron michael-valdron commented Jul 7, 2022 •
edited
Loading

Please specify the area for this PR
registry-library

What does does this PR do / why we need it:

Adds consumable functions in regards to downloading starter projects for stacks. In addition, adds util functions and additions to testing.

Which issue(s) this PR fixes:

Fixes #?
fixes devfile/api#842

PR acceptance criteria:

  • Test (WIP)

Documentation (WIP)

How to test changes / Special notes to the reviewer:

@michael-valdron
splitVersionFromStack, GetStackIndex, and GetStackLink util functions…
a898c61 
… created.

Signed-off-by: Michael Valdron <mvaldron@redhat.com>
@michael-valdron
Function for downloading a stack's starter project as bytes added.
921b5c6 
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
@michael-valdron
index/generator dependency under registry-library updated.
1a16f39 
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
@michael-valdron
registry-library setup test server fixture added.
2b770a7 
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
@michael-valdron
DownloadStarterProject function source added.
7d1d2b8 
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
@michael-valdron
testing schema indices moved to global scope. schema index handle fun…
2f3819f 
…ction added. GetStackIndex test function added.

Signed-off-by: Michael Valdron <mvaldron@redhat.com>
@michael-valdron
additional versions with links added to test schema indices
9e0e4e8 
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
@michael-valdron
GetStackLink test function added.
caa9c18 
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
@michael-valdron
case for no default version added.
4405905 
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
@michael-valdron
corrected mistake in DownloadStarterProjectAsBytes with URL
823604e 
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
@michael-valdron
DownloadStarterProjectAsBytes test function definition and server set…
acfbecb 
… up source added.

Signed-off-by: Michael Valdron <mvaldron@redhat.com>
@michael-valdron
DownloadStarterProjectAsBytes test function source completed.
93361ed 
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
@michael-valdron
IsStarterProjectExists function added.
32d637c 
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
@michael-valdron
fixed starter project url construction.
aad1224 
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
@michael-valdron
fixed test condition for DownloadStarterProject.
b7854c0 
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
@michael-valdron
IsStarterProjectExists test function added.
befa4a5 
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
@michael-valdron
additional comments added.
e8beced 
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
@michael-valdron
DownloadStarterProjectAsDir function for downloading starter project …
48db3e4 
…into directory added.

Signed-off-by: Michael Valdron <mvaldron@redhat.com>
@michael-valdron
download cmd added.
714de9d 
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
@michael-valdron
registry library download starter project integration test case added.
88ac426 
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
@michael-valdron
registry library download starter project V2 integration test case ad…
1b10bd8 
…ded.

Signed-off-by: Michael Valdron <mvaldron@redhat.com>
@michael-valdron michael-valdron marked this pull request as ready for review July 8, 2022 21:44
@michael-valdron michael-valdron requested a review from kim-tsao July 11, 2022 19:21
kim-tsao
kim-tsao reviewed Jul 11, 2022
View reviewed changes
@michael-valdron
Missing TestDownloadStarterProject and TestDownloadStarterProjectAsDi…
9d0cd23 
…r test functions added.

Signed-off-by: Michael Valdron <mvaldron@redhat.com>
@michael-valdron
changed os.Open to os.OpenFile under DownloadStarterProject to allow …
323f0ba 
…for file writing.

Signed-off-by: Michael Valdron <mvaldron@redhat.com>
kim-tsao
kim-tsao reviewed Jul 12, 2022
View reviewed changes
@michael-valdron
Validation of stack/version tag added. Improved error checking for Sp…
5ccc975 
…litVersionFromStack. util functions moved to util.go

Signed-off-by: Michael Valdron <mvaldron@redhat.com>
@michael-valdron
test functions for SplitVersionFromStack and ValidateStackVersionTag …
8ff641b 
…added.

Signed-off-by: Michael Valdron <mvaldron@redhat.com>
@michael-valdron
update documentation
865dabd 
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
@michael-valdron
refactored setUpTestServer and test functions to remove duplication o…
750f1da 
…f handlers.

Signed-off-by: Michael Valdron <mvaldron@redhat.com>
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 12, 2022
@openshift-ci
Copy link

openshift-ci bot commented Jul 12, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kim-tsao, michael-valdron
To complete the pull request process, please assign johnmcollier after the PR has been reviewed.
You can assign the PR to them by writing /assign @johnmcollier in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@michael-valdron michael-valdron merged commit 57e97bd into devfile:main Jul 12, 2022
@michael-valdron michael-valdron deleted the dl-sp-libraryapi branch July 13, 2022 15:58
@michael-valdron michael-valdron mentioned this pull request Jul 14, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kim-tsao kim-tsao kim-tsao approved these changes

@johnmcollier johnmcollier Awaiting requested review from johnmcollier

@maysunfaisal maysunfaisal Awaiting requested review from maysunfaisal

Assignees

@kim-tsao kim-tsao

Labels

lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

download-starter-project Library API

2 participants

@michael-valdron @kim-tsao