proxy support for registry

[kim-tsao]

Signed-off-by: Kim Tsao ktsao@redhat.com

Please specify the area for this PR
/area registry

What does does this PR do / why we need it:
Introduces proxy support for the registry. Clients such as OCP allow their users to set up a proxy server (typical of air-gapped environments) but this will cause the devfile registry to be unreachable. The fix is to update our custom HTTP transport to recognize the proxy that's set in the environment.

Which issue(s) this PR fixes:

Fixes #?

devfile/api#897

PR acceptance criteria:

• [x ] Test (WIP)

Documentation (WIP)

• Does the REST API doc need to be updated with your changes?
• Does the registry library doc need to be updated with your changes?

How to test changes / Special notes to the reviewer:

• Console QE tested on a remote OCP cluster with an HTTP proxy and confirmed the devfile catalog was able to load. I also inspected the console logs and confirmed the proxy was being picked up from the environment. Note, this set up was for test purposes only. Once the fix is final, only trusted, HTTPS proxies will be supported in the console. See https://docs.openshift.com/container-platform/4.11/security/certificate_types_descriptions/proxy-certificates.html

[openshift-ci]

@kim-tsao: The label(s) area/registry cannot be applied, because the repository doesn't have them.

Details

In response to this:

Signed-off-by: Kim Tsao ktsao@redhat.com

Please specify the area for this PR
/area registry

What does does this PR do / why we need it:
Introduces proxy support for the registry. Clients such as OCP allow their users to set up a proxy server (typical of air-gapped environments) but this will cause the devfile registry to be unreachable. The fix is to update our custom HTTP transport to recognize the proxy that's set in the environment.

Which issue(s) this PR fixes:

Fixes #?

devfile/api#897

PR acceptance criteria:

• [x ] Test (WIP)

Documentation (WIP)

• Does the REST API doc need to be updated with your changes?
• Does the registry library doc need to be updated with your changes?

How to test changes / Special notes to the reviewer:

• Console QE tested on a remote OCP cluster with an HTTP proxy and confirmed the devfile catalog was able to load. I also inspected the console logs and confirmed the proxy was being picked up from the environment. Note, this set up was for test purposes only. Once the fix is final, only trusted, HTTPS proxies will be supported in the console. See https://docs.openshift.com/container-platform/4.11/security/certificate_types_descriptions/proxy-certificates.html

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnmcollier, kim-tsao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [johnmcollier]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment