Skip to content

Conversation

@kadel
Copy link
Member

@kadel kadel commented Feb 22, 2022

What does this PR do?:

Which issue(s) this PR fixes:

fixes devfile/api#777

PR acceptance criteria:

  • Contributing guide
    Have you read the devfile registry contributing guide and followed its instructions?
  • Test automation
    Does this repository's tests pass with your changes?
  • Documentation
    Does any documentation need to be updated with your changes?

How to test changes / Special notes to the reviewer:

Signed-off-by: Tomas Kral <tkral@redhat.com>
Copy link
Contributor

@elsony elsony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Looks good to me label Feb 28, 2022
@openshift-ci
Copy link

openshift-ci bot commented Feb 28, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: elsony, kadel

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@elsony
Copy link
Contributor

elsony commented Feb 28, 2022

/retest

2 similar comments
@johnmcollier
Copy link
Member

/retest

@johnmcollier
Copy link
Member

/retest

@openshift-ci
Copy link

openshift-ci bot commented Mar 1, 2022

@kadel: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v4.7-registry-test 82219cb link true /test v4.7-registry-test

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@johnmcollier
Copy link
Member

CI failures due to known issue which has been fixed, I'm gonna merge this, no point retesting since the modified stacks (python, python-django) were fine.

@johnmcollier johnmcollier merged commit a58b55f into devfile:main Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm Looks good to me

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Commands from Python devfile should be improved

3 participants