refactor!: reframe devframe positioning + rename Vite integration#2
Merged
Conversation
Reframe the docs/skill to position devframe as a portable, framework- and build-tool-agnostic asset rather than a single-tool surface that "lacks" hub features. Vite DevTools is now described as one host built on devframe, reached via the renamed `vite` adapter (was the `kit` adapter); the docs no longer enumerate things devframe doesn't provide and instead point at Vite DevTools or custom adapters as the escape valve. The previous `vite` SPA-mounting plugin is no longer an adapter — moved to `devframe/helpers/vite` and the factory renamed `createVitePlugin` → `viteDevBridge`. Updated the `@devframes/nuxt` consumer, internal JSDoc, error doc DF0033, tsnapi snapshots, `DevframeRuntime` type literal, and rebranded the client-side `[Vite DevTools]` timeout error to `[devframe]`. The `vite-devtools-auth` BroadcastChannel literal is kept for cross-tab interop with the existing Vite DevTools auth page.
tsnapi emits interfaces alphabetically; the hand-edited snapshot had ViteDevBridgeOptions before DevframeVitePlugin, causing a snapshot mismatch on all CI matrix jobs. Reordered to DevframeVitePlugin first. Also picks up tsdown's idempotent re-sort of package.json exports (./helpers/vite slotted between ./constants and ./node).
antfu
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
viteadapter), not a hub that holds "missing" features. The docs no longer enumerate what devframe doesn't provide; users who want hub-level features (docks, palette, terminals, …) are pointed at Vite DevTools or custom adapters.createPluginFromDevframefrom@vitejs/devtools-kit/node) to theviteadapter throughout the user-facing surfaces.createVitePluginout of the adapter list — it's not actually an adapter. Relocated todevframe/helpers/viteand renamedcreateVitePlugin→viteDevBridge.@devframes/nuxtconsumer, error doc DF0033, internal JSDoc,DevframeRuntimeliteral, and tsnapi snapshots updated to match.[Vite DevTools]timeout error to[devframe]; generalize a couple of embed-context JSDoc comments. TheBroadcastChannel('vite-devtools-auth')literal is kept (cross-tab interop with the existing Vite DevTools auth page) and annotated.Test plan
pnpm --filter devframe buildpnpm -r typecheckpnpm test— confirm the newhelpers/vite.snapshot.{js,d.ts}are accepted and no staleadapters/vitesnapshot remainspnpm docs:devand spot-check the rewritten guide pages@devframes/nuxtstill bridges in dev mode after the import path change