Move main plugin class to a PSR-4 file#29
Merged
HPiirainen merged 2 commits intodevgeniem:masterfrom May 8, 2024
Merged
Conversation
szepeviktor
commented
May 8, 2024
HPiirainen
requested changes
May 8, 2024
Contributor
HPiirainen
left a comment
HPiirainen
left a comment
There was a problem hiding this comment.
Thanks, good stuff! If you can move the use statements from the original plugin.php to the new Plugin class, then we're good to go 👍
Contributor
There was a problem hiding this comment.
Move the use statements from this class...
| */ | ||
|
|
||
| namespace Geniem\Oopi; | ||
|
|
Contributor
There was a problem hiding this comment.
... to this class so everything works correctly 👍
Contributor
Author
There was a problem hiding this comment.
Sorry. This is the first time I use a computer 🙃
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@HPiirainen Noticed the strange array in PSR-4 autoloading.