Merged
Conversation
Contributor
Author
|
fixed #403 |
Contributor
|
In windows-rs 0.61, how does .get() work? Is that the blocking form, since it isn't awaited now? |
Contributor
|
Ok, yup, answered my own question by looking up the relevant windows-rs PR: microsoft/windows-rs#3213 .get() is blocking. This can't come in as is, we need to use the IntoFuture() casts and await as we currently do. |
qdot
added a commit
that referenced
this pull request
Apr 20, 2025
Can't block, but the conversion is easy enough that I just want to get it done, so I'm handling it.
Contributor
|
Ok, I did the fix myself 'cause it was simple and I'd like to get windows 0.61 in. |
qdot
added a commit
that referenced
this pull request
Apr 21, 2025
Can't block, but the conversion is easy enough that I just want to get it done, so I'm handling it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
windowsto 0.61 and fix;anyhowand updaterandfor example;PoisonError] to [Error] for replaceunwraptomap_err;