Skip to content

[FEATURE REQUEST] Check placement of new entries in devicon.json #1327

@BenSouchet

Description

@BenSouchet

I have searched through the issues and didn't find my problem.

  • Confirm

Problem

Currently when someone contribute to Devicon via a PR to add a new set of icons this person can add the new entry in the devicon.json file anywhere.

But ignoring the alphabetic order in the JSON file can lead to issues / bugs / mistakes and merge conflicts.

Normally the entries order in the devicon.json file should reflect as close as possible the automatic order of the icons/ folder.

Possible Solution

Add an element in the PR checklist
+
Add a required verification from the PR reviewer(s)
+
Add a line in the documentation ( https://github.com/devicons/devicon/wiki/Updating-the-%60devicon.json%60 )

Additional information

This is a rather small enhancement but this can improve the robustness of the project, and the solution isn't heavy to add to the current pipeline / process.

Thanks

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementin-developThe fix/feature is present in `develop` branch but not merged into `master` yet

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions