Skip to content

Question on what to do to css files in the new build task. #286

@Thomas-Boi

Description

@Thomas-Boi

Hey @amacado,

I would like to ask for your inputs on the generation of the css files and the branch workflow trigger.

Quick summary

I am currently upgrading the current devicon.json to a newer version that would include the aliases and color attribute (see this pr). Beside the changes to this file, I'm also working on a new gulp task to generate css files (devicon-alias.css and devicon-color.css) based on the new devicon.json.

As you can see in the pr, we talked about removing the alias and the color css file completely. However, we later talked about how we don't want to break compatibility while we upgrade the repo. So as a confirmation, should I delete these css files after I generate the devicon.min.css? I'm working on the gulp tasks right now and I can pipe the outputs into a file. It's also faster appending to existing file as well but we would have a bunch of css files sitting around. Let me know what you think.

Metadata

Metadata

Assignees

No one assigned

    Labels

    discussionCommunity discussions about changes/features/..

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions