Skip to content

[BUG] get-build-release-message not getting the PRs that are past the Release date but are merged after. #841

@Thomas-Boi

Description

@Thomas-Boi

Bug description

As seen in this PR, the build-bot only found 4 PRs:
image

There are actually 6 icons that should be included. These are not found by the bot because I coded it like this:

  • Query the API for the PRs
  • Get all the PRs UP UNTIL the PR with a name matching "Release v"

The two missing PRs (bottom two here which were added manually by me), when searched on GitHub, shows up AFTER the "Release v" PR. I think GitHub sorted them by open dates, not merged date.

Possible fixes or solutions

Find a way to query the APIs based on merge dates rather than opened dates. If not, probably goes past the end PR a little bit.

Additional information

Not critical but we should have it.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugUse this label for pointing out bugsin-developThe fix/feature is present in `develop` branch but not merged into `master` yet

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions