Skip to content

Fix checkbot's check version issue #1089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Thomas-Boi merged 1 commit into from
Mar 23, 2022
Merged

Fix checkbot's check version issue #1089

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/scripts/build_assets/util.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,3 +75,7 @@ def find_object_added_in_pr(icons: List[dict], pr_title: str):
def is_svg_name_valid(filename: str):
return valid_svg_filename_pattern.search(filename) is not None

valid_svg_version_pattern = re.compile(r"^(original|plain|line)(-wordmark)?$")
def is_svg_version_valid(version):
return valid_svg_version_pattern.search(version) is not None

4 changes: 2 additions & 2 deletions .github/scripts/check_icon_pr.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ def check_devicon_object(icon: dict):
err_msgs.append("- must contain at least 1 svg version in a list.")

for version in icon["versions"]["svg"]:
if not util.is_svg_name_valid(version):
if not util.is_svg_version_valid(version):
err_msgs.append(f"- Invalid version name in versions['svg']: '{version}'. Must match regexp: (original|plain|line)(-wordmark)?")
except KeyError:
err_msgs.append("- missing key: 'svg' in 'versions'.")
Expand All @@ -92,7 +92,7 @@ def check_devicon_object(icon: dict):
err_msgs.append("- must contain at least 1 font version in a list.")

for version in icon["versions"]["font"]:
if not util.is_svg_name_valid(version):
if not util.is_svg_version_valid(version):
err_msgs.append(f"- Invalid version name in versions['font']: '{version}'. Must match regexp: (original|plain|line)(-wordmark)?")
except KeyError:
err_msgs.append("- missing key: 'font' in 'versions'.")
Expand Down