Skip to content

Conversation

@thehedgefrog
Copy link
Contributor

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here

This PR closes NONE

Link to prove your SVG is correct and up-to-date.

Portainer website

@thehedgefrog thehedgefrog changed the title new icon: <i>Portainer</i> (<i>original, original-wordmark</i>) new icon: Portainer (original, original-wordmark) Mar 26, 2022
@Panquesito7 Panquesito7 added the feature:icon PR when a new icon is ready to be added to the collection label Mar 27, 2022
@amacado amacado added the bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger label Mar 27, 2022
@github-actions
Copy link
Contributor

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

Here are the SVGs as intepreted by Icomoon when we upload the files:
Imgur Images

Here are the zoomed-in screenshots of the added icons as SVGs:
Imgur Images Imgur Images

Here are the icons that will be generated by Icomoon:
Imgur Images

Here are the zoomed-in screenshots of the added icons as icons:
Imgur Images Imgur Images

Here are the colored versions:
Imgur Images Imgur Images

The maintainers will now check for:

  1. The number of Glyphs matches the number of SVGs that were selected.
  2. The icons (second group of pictures) look the same as the SVGs (first group of pictures).
  3. The icons are of high quality (legible, matches the official logo, etc.)

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.

Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice.

Cheers,
Peek Bot 😊

@amacado amacado changed the title new icon: Portainer (original, original-wordmark) new icon: portainer (original, original-wordmark) Mar 27, 2022
@amacado
Copy link
Member

amacado commented Mar 27, 2022

@thehedgefrog could re-create the pull request with correct title? Our workflow seems to not work when the title is changed later. Even if re-triggered it will pick up the original pull request title.

@Thomas-Boi this might be something we could work on?

@amacado amacado closed this Mar 27, 2022
@Thomas-Boi Thomas-Boi reopened this Mar 27, 2022
@Thomas-Boi
Copy link
Member

I think it's working now. It just take sometime for the comment to show up. However, I can definitely add casting strings to lowercase for the future.

@amacado
Copy link
Member

amacado commented Mar 27, 2022

@Thomas-Boi the problem is not the lowercase, it were the html entities in the original title:
https://github.com/devicons/devicon/runs/5708749789?check_suite_focus=true
image

And the problem was that even after changing the title and re-running the task it will pick up the original title and not the updated title. That might be a problem of github actions and not the script itself.

I'm closing this, since portainer was merged in #1105.

@amacado amacado closed this Mar 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger feature:icon PR when a new icon is ready to be added to the collection

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants