-
Notifications
You must be signed in to change notification settings - Fork 2.4k
new icon: YAML (original) #1142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi! :) Thank you for picking up yaml. While looking through the files I noticed some things you might want to apply/fix before this pr is ready:
- You introduced many new whitespaces in the
devicon.json, while this is probably auto-added by a style in your idea: Please remove the whitespaces to follow our previous style - As our bot noticed there's also no
fontdefinition in thedevicon.jsonforyamland "SVG" must be be written lowercase :) - The icon itself looks non-centered. It seems like there is some space bellow but non above.
- Also it looks like there is a small fine square around the logo (which is non intended). This might be a error in the github preview as well
You might take an additional look at https://github.com/devicons/devicon/wiki/Overview-on-Submitting-Icons and/or https://github.com/devicons/devicon/wiki/Example-of-Submitting-Icons-to-the-Repository
greetings and happy easter! 🐰
This reverts commit 04fabaf.
Yes, it looks like the VSCode JSON formatter linted the file. Can you tell me which lintter are you guys using?
I think I now understand what the
I understand. But to my (extremely limited) knowledge of SVG that is a consequence of using
I don't see that square thb. Could you point to it in the SVG code, please? |
|
Hi! I'm the Check our CONTRIBUTING guide for more details regarding these errors. Please address these issues. When you update this PR, I will check your SVGs again. Thanks for your help, |
Removes `plain-white` and `plain-black` versions
|
Hi there, I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io. Here are the SVGs as intepreted by Icomoon when we upload the files: Here are the zoomed-in screenshots of the added icons as SVGs: Here are the icons that will be generated by Icomoon: Here are the zoomed-in screenshots of the added icons as icons: Here are the colored versions: The maintainers will now check for:
In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done. Thank you for contributing to Devicon! I hope that your icons are accepted into the repository. Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice. Cheers, |
amacado
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.







Double check these details before you open a PR
developbranch.devicon.jsonfile as seen hereThis PR closes NONE
Link to prove your SVG is correct and up-to-date.
The SVG itself I downloaded it from the YAML Wikipedia page and used the tools listed in this repo to fix it to Devicon standards. But, as shown in The YAML project GitHub organization, it is the correct and official one.