Skip to content

Conversation

@Panquesito7
Copy link
Member

Things added/changed:

  • Add original-wordmark aliases for Liquibase.
    • Thanks to @kilian-paquier for spotting the bug!

@Panquesito7 Panquesito7 added the bug Use this label for pointing out bugs label Jun 28, 2022
@Panquesito7 Panquesito7 requested a review from amacado June 28, 2022 18:14
@kilianpaquier
Copy link
Contributor

@Panquesito7 Isn't there a missing }, { for the second alias ?

@Panquesito7
Copy link
Member Author

@Panquesito7 Isn't there a missing }, { for the second alias ?

Good catch! Thank you. 🙂

Co-authored-by: kilian-paquier <kilian-paquier@users.noreply.github.com>
@kilianpaquier
Copy link
Contributor

kilianpaquier commented Jun 28, 2022

@Panquesito7 Isn't there a missing }, { for the second alias ?

Good catch! Thank you. 🙂

No problem 🙂 ! Seems good to me

kilianpaquier
kilianpaquier previously approved these changes Jun 28, 2022
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than an extra whitespace it looks good ! :D

Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Snailedlt Snailedlt merged commit af1e294 into develop Jul 23, 2022
Snailedlt added a commit to Snailedlt/devicon that referenced this pull request Oct 15, 2022
* fix: add `original-wordmark` aliases for Liquibase

Co-authored-by: kilian-paquier <kilian-paquier@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>

Co-authored-by: kilian-paquier <kilian-paquier@users.noreply.github.com>
Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>
Snailedlt added a commit to Snailedlt/devicon that referenced this pull request Oct 15, 2022
* fix: add `original-wordmark` aliases for Liquibase

Co-authored-by: kilian-paquier <kilian-paquier@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>

Co-authored-by: kilian-paquier <kilian-paquier@users.noreply.github.com>
Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>
Snailedlt added a commit to Snailedlt/devicon that referenced this pull request Oct 15, 2022
* fix: add `original-wordmark` aliases for Liquibase

Co-authored-by: kilian-paquier <kilian-paquier@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>

Co-authored-by: kilian-paquier <kilian-paquier@users.noreply.github.com>
Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>
@Panquesito7 Panquesito7 deleted the liquibase_alias branch May 3, 2023 00:59
@Snailedlt Snailedlt mentioned this pull request Feb 5, 2024
GCHQDeveloper926 pushed a commit to GCHQDeveloper926/devicon that referenced this pull request Dec 20, 2024
* fix: add `original-wordmark` aliases for Liquibase

Co-authored-by: kilian-paquier <kilian-paquier@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>

Co-authored-by: kilian-paquier <kilian-paquier@users.noreply.github.com>
Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Use this label for pointing out bugs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants