Skip to content

Conversation

@AcmeGamers
Copy link
Contributor

@AcmeGamers AcmeGamers commented Jul 3, 2022

Double check these details before you open a PR

  • [ ✔ ] PR does not match another non-stale PR currently opened
  • [ ✔ ] PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • [ ✔ ] PR's base is the develop branch.
  • [ ✔ ] Your icons are inside a folder as seen here
  • [ ✔ ] SVG matches the standards laid out here
  • [ ✔ ] A new object is added in the devicon.json file as seen here

Link to prove your SVG is correct and up-to-date.

https://www.vite.org/

@AcmeGamers AcmeGamers changed the title new icon: vite (Original, Plain, Plain wordmark) new icon: vite (original, original wordmark) Jul 3, 2022
@kilianpaquier
Copy link
Contributor

Hello @AcmeGamers, I reviewed your PR #1253, can you follow the recommandations and standards for this PR too ?

@AcmeGamers
Copy link
Contributor Author

Hello @AcmeGamers, I reviewed your PR #1253, can you follow the recommandations and standards for this PR too ?

For sure, I will get them fixed in a matter of a moment

@MKMonkeyCat
Copy link

did u finished that? bro
(This sentence was translated by google

@Snailedlt Snailedlt added the feature:icon PR when a new icon is ready to be added to the collection label Jul 28, 2022
@Snailedlt
Copy link
Collaborator

@AcmeGamers Please read and implement the changes listed above when you have time

@Snailedlt
Copy link
Collaborator

Let us know if you need any help with the changes :)
We can collaborate on the PR if you want

@Snailedlt Snailedlt added the stale PRs that haven't had any activity for a while and old issues label Oct 1, 2022
@Snailedlt Snailedlt closed this Oct 26, 2022
@Snailedlt
Copy link
Collaborator

Closed bacuase the PR was stale, and replaced with #1472

@lunatic-fox lunatic-fox added in-develop The fix/feature is present in `develop` branch but not merged into `master` yet and removed stale PRs that haven't had any activity for a while and old issues labels Dec 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature:icon PR when a new icon is ready to be added to the collection in-develop The fix/feature is present in `develop` branch but not merged into `master` yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants