-
Notifications
You must be signed in to change notification settings - Fork 2.4k
new icon: hardhat (original) #1357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Fix issue with npm publish script
Build preparation for release v2.15.1
Created hardhat folder and added its respective icon
In response to [ICON REQUEST]: Hardhat icon devicons#1355
Snailedlt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor changes that need to be done
Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>
knight-95
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please check now
knight-95
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated Viewbox to 0 0 128 128.
Snailedlt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Devicon.json looks good now
Only 3 things left now:
1: remove changes to package.json (see suggestion below)
2: Center and resize icon to fit inside the viewbox
3: Provide a unicolored plain and/or line icon that can be used for fonts. An easy way to do this is to just set all the yellow paths to the same color, and the other paths as transparent
Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>
knight-95
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Centered the svg icon using recommended tools
| @@ -0,0 +1,16 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now the icon is stretched 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@knight-95 still stretched 🙈
knight-95
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added the suggested aliases
This comment was marked as outdated.
This comment was marked as outdated.
1 similar comment
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
knight-95
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Snailedlt 128x128 will make the picture bit unsized 😅, but it works fine...
Try resizing without stretching it. It doesn't have to stretch to fit, just needs to be centered and fit either vertically or horizontally. I would try and resize the original icon again if I were you :) |
SVG Standards
knight-95
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Snailedlt
Changed svg viewBox="0 0 128 128" According to standards given in documentation
Also the icon now looks good :)
Nice, looks better now. Oh and it would be great if you provided a plain icon where the eth logo is transparent and the rest of the icon is the same color :) |
|
env.MESSAGE |
|
By the way on the hardhat website there is a wordmark version of the logo: |
|
@knight-95 Can you add the wordmark icon suggested by @BenSouchet too? 💯 |
|
Hi there, I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io. Here are the SVGs as intepreted by Icomoon when we upload the files: Here are the zoomed-in screenshots of the added icons as SVGs: Here are the icons that will be generated by Icomoon: Here are the zoomed-in screenshots of the added icons as icons: Here are the colored versions: The maintainers will now check for:
In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done. Thank you for contributing to Devicon! I hope that your icons are accepted into the repository. Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice. Cheers, |
|
Superseeded by #1565 |





Double check these details before you open a PR
developbranch.devicon.jsonfile as seen hereThis PR closes NONE
This PR closes #1355 #1356
Link to prove your SVG is correct and up-to-date.
https://hardhat.org/
https://hardhat.org/docs