Skip to content

Conversation

@knight-95
Copy link

@knight-95 knight-95 commented Aug 21, 2022

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here

This PR closes NONE

This PR closes #1355 #1356

Link to prove your SVG is correct and up-to-date.

https://hardhat.org/
https://hardhat.org/docs

Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor changes that need to be done

@Snailedlt Snailedlt added the feature:icon PR when a new icon is ready to be added to the collection label Aug 21, 2022
knight-95 and others added 2 commits August 21, 2022 18:48
Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>
Copy link
Author

@knight-95 knight-95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please check now

Copy link
Author

@knight-95 knight-95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated Viewbox to 0 0 128 128.

Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devicon.json looks good now

Only 3 things left now:
1: remove changes to package.json (see suggestion below)
2: Center and resize icon to fit inside the viewbox
3: Provide a unicolored plain and/or line icon that can be used for fonts. An easy way to do this is to just set all the yellow paths to the same color, and the other paths as transparent

knight-95 and others added 3 commits August 21, 2022 22:45
Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>
Copy link
Author

@knight-95 knight-95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Centered the svg icon using recommended tools

@@ -0,0 +1,16 @@
<?xml version="1.0" encoding="UTF-8"?>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now the icon is stretched 😅

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@knight-95 still stretched 🙈

Copy link
Author

@knight-95 knight-95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added the suggested aliases

@Panquesito7 Panquesito7 added the bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger label Aug 23, 2022
@github-actions

This comment was marked as outdated.

1 similar comment
@github-actions

This comment was marked as outdated.

@Panquesito7 Panquesito7 added bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger labels Aug 23, 2022
@github-actions

This comment was marked as outdated.

Copy link
Author

@knight-95 knight-95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Snailedlt 128x128 will make the picture bit unsized 😅, but it works fine...

@Snailedlt
Copy link
Collaborator

@Snailedlt 128x128 will make the picture bit unsized sweat_smile, but it works fine...

Try resizing without stretching it. It doesn't have to stretch to fit, just needs to be centered and fit either vertically or horizontally.

I would try and resize the original icon again if I were you :)

Copy link
Author

@knight-95 knight-95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Snailedlt
Changed svg viewBox="0 0 128 128" According to standards given in documentation
Also the icon now looks good :)

@Snailedlt
Copy link
Collaborator

@Snailedlt Changed svg viewBox="0 0 128 128" According to standards given in documentation Also the icon now looks good :)

Nice, looks better now.
Only thing missing is to resize so it fits horizontally and center it. You can use one of the recommended tools in the wiki to do that.

Oh and it would be great if you provided a plain icon where the eth logo is transparent and the rest of the icon is the same color :)

@Panquesito7 Panquesito7 added bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger labels Aug 24, 2022
@github-actions
Copy link
Contributor

env.MESSAGE

@BenSouchet
Copy link
Contributor

By the way on the hardhat website there is a wordmark version of the logo:
https://hardhat.org/_next/static/media/hardhat-logo-dark.484eb916.svg
and / or
https://hardhat.org/_next/static/media/hardhat-logo.5c5f687b.svg

@Snailedlt Snailedlt added bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger labels Sep 11, 2022
@Snailedlt
Copy link
Collaborator

@knight-95 Can you add the wordmark icon suggested by @BenSouchet too? 💯

@github-actions
Copy link
Contributor

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

Here are the SVGs as intepreted by Icomoon when we upload the files:
Imgur Images

Here are the zoomed-in screenshots of the added icons as SVGs:
Imgur Images

Here are the icons that will be generated by Icomoon:
Imgur Images

Here are the zoomed-in screenshots of the added icons as icons:
Imgur Images

Here are the colored versions:
Imgur Images

The maintainers will now check for:

  1. The number of Glyphs matches the number of SVGs that were selected.
  2. The icons (second group of pictures) look the same as the SVGs (first group of pictures).
  3. The icons are of high quality (legible, matches the official logo, etc.)

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.

Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice.

Cheers,
Peek Bot 😊

@lunatic-fox lunatic-fox added the stale PRs that haven't had any activity for a while and old issues label Dec 6, 2022
@Snailedlt
Copy link
Collaborator

Superseeded by #1565

@Snailedlt Snailedlt closed this Dec 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger feature:icon PR when a new icon is ready to be added to the collection stale PRs that haven't had any activity for a while and old issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants